fix(iluvatar): compile bindings without CMake CUDA language#613
Merged
Conversation
Collaborator
Author
|
Ascend ci 在部分几个测例报错,在 pr #614 中有修复 |
bitzyz
previously approved these changes
May 20, 2026
4d1bbdc to
1ee76bf
Compare
voltjia
approved these changes
May 20, 2026
bitzyz
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
clang++is not invoked with CMake-added-x cudafor generated binding dispatch sources.clang++ -x ivcorecustom commands, while leaving NVIDIA and other backend paths unchanged.Motivation
The generated
.ccbinding dispatch sources were forced onto CMake's CUDA source path for both NVIDIA and Iluvatar. On Iluvatar, CMake's CUDA language flow appends-x cuda, which can make CoreXclang++segfault. This PR keeps Iluvatar on the working CoreX-x ivcorecompile path without changing other hardware platforms.Because the Iluvatar dispatch sources now use explicit custom commands instead of CMake's normal source dependency scanner, the custom commands also write Ninja depfiles with
-MMD -MFandDEPFILE. This preserves incremental-build correctness when included generated headers or Iluvatar implementation headers change.Closes N/A
Type of Change
fix— bug fixfeat— new feature / new operator / new platformperf— performance improvement (no behavioral change)refactor— code restructuring without behavior changetest— adding or fixing tests onlydocs— documentation onlybuild/ci— build system or CI configurationchore— tooling, formatting, or other non-code changesPlatforms Affected
WITH_CPU)WITH_NVIDIA)WITH_ILUVATAR)WITH_METAX)WITH_CAMBRICON)WITH_MOORE)WITH_ASCEND)WITH_TORCH)Test Results on Supported Platforms
pytestResultci / unit / nvidiaandci-v2-shadow / ci-v2-shadow / nvidiapassed. NVIDIA CUDA source handling remains unchanged.ci / unit / iluvatarandci-v2-shadow / ci-v2-shadow / iluvatarpassed. Also verified local compile and wheel install ininfiniops-dev/iluvatar:latestwith CoreX host mount.ci / unit / metaxandci-v2-shadow / ci-v2-shadow / metaxpassed. Not affected by this PR.ci / unit / cambriconandci-v2-shadow / ci-v2-shadow / cambriconpassed. Not affected by this PR.ci / unit / mooreandci-v2-shadow / ci-v2-shadow / moorepassed. Not affected by this PR.ci / unit / ascendandci-v2-shadow / ci-v2-shadow / ascendfailed. Ascend is not changed by this PR.GitHub Actions status
As of the latest PR check query on 2026-05-20 UTC:
Local Iluvatar build output summary
Benchmark / Performance Impact
N/A. This is a build-path fix only.
Notes for Reviewers
The intended invariant is that NVIDIA still uses CMake
LANGUAGE CUDAfor generated binding sources, while Iluvatar uses explicit custom commands only forgenerated_dispatch*.cc. Ordinary generated pybind sources remain CXX for Iluvatar. The explicit Iluvatar dispatch commands emit compiler depfiles so header and kernel implementation changes are tracked by Ninja incremental builds.Checklist
Title, Branch, and Commits
<type>/xxx-yyyy-zzzz.master; branch is based onorigin/master.fixup!/squash!/wipcommits remain.Scope and Design
CMakeLists.txtandsrc/CMakeLists.txt.General Code Hygiene
git diff --check HEAD~1 HEADpasses.C++ Specific
N/A. No C++ source/header files were changed.
Python Specific
N/A. No Python files were changed.
Testing
Build, CI, and Tooling
pip install . --no-build-isolation --no-depssucceeds in the Iluvatar development image.build.ninja.clang-format,ruff, matrix generation, and unit jobs for NVIDIA, Iluvatar, MetaX, Moore, and Cambricon passed.clang-format.ymlandruff.ymldo not apply to the modified CMake files.Documentation
Security and Safety